Skip to content

[MOB-12189] add-tests-to-iterableinappmanager #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MOB-12189] add-tests-to-iterableinappmanager #712

wants to merge 3 commits into from
+415 −0

Conversation

lposen
Copy link
Contributor

@lposen lposen commented Oct 3, 2025 •
edited by atlassian bot
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

Add tests to IterableInAppManager

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

Lines Statements Branches Functions
Coverage: 52%
 52.19% (250/479) 23.28% (44/189) 45.51% (71/156)

@qltysh qltysh
Copy link

qltysh bot commented Oct 3, 2025 •
edited
Loading

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will increase coverage by 0.84%.

File Coverage Changes
Path File Coverage Δ Indirect
src/inApp/classes/IterableInAppManager.ts 26.7 √
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen added the tests This issue or PR concerns test coverage. If PR, it should only contain tests. label Oct 14, 2025
Base automatically changed from MOB-12188-add-tests-for-iterablehtmlinappcontent to master October 16, 2025 00:14
evantk91
evantk91 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some comments for future work

src/__mocks__/MockRNIterableAPI.ts
};
resolve(mockHtmlContent);
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice mock

src/inApp/classes/IterableInAppManager.test.ts
// WHEN calling removeMessage with invalid enum values
// THEN it should not throw an error (values are passed through)
expect(() => {
manager.removeMessage(mockMessage, 999 as IterableInAppLocation, 888 as IterableInAppDeleteSource);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want these errors to be handled in the future for invalid enum values.

src/inApp/classes/IterableInAppManager.test.ts
expect(() => {
manager.showMessage(mockMessage, 'true' as unknown as boolean);
manager.setReadForMessage(mockMessage, 'false' as unknown as boolean);
manager.setAutoDisplayPaused('true' as unknown as boolean);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evantk91 evantk91 evantk91 approved these changes

Assignees

No one assigned

Labels

tests This issue or PR concerns test coverage. If PR, it should only contain tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lposen @evantk91